Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Fix enum comparison on inject status #1854

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[backend] Fix enum comparison on inject status #1854

merged 2 commits into from
Nov 14, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Nov 13, 2024 •
edited
Loading

Proposed changes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 13, 2024
@savacano28 savacano28 self-assigned this Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.42%. Comparing base (5609c26) to head (937f4e2).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1854      +/-   ##
============================================
+ Coverage     32.37%   32.42%   +0.05%     
  Complexity     1623     1623              
============================================
  Files           561      561              
  Lines         16861    16834      -27     
  Branches        984      984              
============================================
  Hits           5459     5459              
+ Misses        11160    11133      -27     
  Partials        242      242

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review November 14, 2024 07:00
@savacano28 savacano28 merged commit b0bea51 into master Nov 14, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/fix-enum-comparison branch November 14, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumejparis guillaumejparis guillaumejparis approved these changes

Assignees

@savacano28 savacano28

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savacano28 @guillaumejparis